feat: add genre/studio/network view to Discover results #1067
Conversation
TheCatLady
force-pushed
the
feature/discover-genres
branch
4 times, most recently
from
5262bbc
to
bdc5579
Compare
TheCatLady
force-pushed
the
feature/discover-genres
branch
from
bdc5579
to
a22d207
Compare
TheCatLady
changed the title
TheCatLady
force-pushed
the
feature/discover-genres
branch
from
9038843
to
a646347
Compare
| @@ -368,17 +378,18 @@ class TheMovieDb extends ExternalAPI { | |||
| page, | |||
| include_adult: includeAdult, | |||
| language, | |||
| with_release_type: '3|2', | |||
There was a problem hiding this comment.
It was removing valid results (e.g., items which only have a digital release). I'm unsure why this was added in the first place?
There was a problem hiding this comment.
It ignores the region without it, from what we saw.
There was a problem hiding this comment.
@sct It didn't seem to be the case when I tested, but let me do some more testing to verify.
There was a problem hiding this comment.
@sct I verified that it does respect the region without with_release_type being set. with_release_type is just an additional filter so that returned results must have at least one release of the specified types in the region. Without with_release_type, results are just required to have a release of any type for the region.
Setting this value to 3|2 just made the region setting appear to do more, since it limited the results to items with a theatrical release in the specified region. I don't think this is desirable, since it filters out items that are exclusive to streaming services, for example.
TheCatLady
force-pushed
the
feature/discover-genres
branch
from
7aa3dd1
to
a091b5a
Compare
TheCatLady
force-pushed
the
feature/discover-genres
branch
from
a091b5a
to
4965281
Compare
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Adds filtered "Discover" views by genre, studio, and network at:
/discover/movies/genre/{genreId}/discover/tv/genre/{genreId}/discover/movie/studio/{studioId}/discover/tv/network/{networkId}Links to these views added to movie & TV detail pages.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed