fix(ui): add alt prop to studio/network logos & fix blinking text cursor #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
bugfix/ui/studio-network-img-alt-text
branch
from
1591a2b
to
63189a7
Compare
|
Also a little torn as to whether the page heading (not the page title) should simply be the name of the studio/network, to match the meaning/behavior when there is no logo. I feel like it definitely works for studios, but network names are sometimes really short and it can look odd. 🤔 |
sct
approved these changes
Mar 5, 2021
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no
alttext for the studio/network logos on the filtered Discover pages, so this PR adds that.Also noticed that a blinking text cursor would appear either before/after the logos, so fixed that as well.
Screenshot (if UI-related)
Blinking text cursor:
To-Dos
yarn buildIssues Fixed or Closed
N/A