feat(email): add support for pgp encrypting notifications #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
reviewed
Mar 10, 2021
TheCatLady
reviewed
Mar 10, 2021
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
TheCatLady
reviewed
Mar 10, 2021
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
TheCatLady
reviewed
Mar 10, 2021
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
TheCatLady
reviewed
Mar 10, 2021
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
JHilmarch
reviewed
Mar 10, 2021
There was a problem hiding this comment.
Fancy stuff :) Snowden is proud of you!
I was concentrating on the readability of the code. Please read my comments and consider my suggestions for improvements.
When going to beta you can consider including the PgpEncrypter into a scenario-test:
- Generate a real world email
- Encrypt it
- Decrypt it
- Assert generated and decrypted email content is the same
TheCatLady
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Use new form-input-field global CSS class (added in 1be97fe)
src/components/UserProfile/UserSettings/UserNotificationSettings/index.tsx
Outdated
Show resolved
Hide resolved
sct
approved these changes
Mar 14, 2021
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a field to the user profile for adding PGP Key. If it exists it will be used to encrypt the email notification sent when sending email notifications to the user.
To-Dos
yarn buildyarn i18n:extract