fix(ui): sort regions & languages by their localized names rather than their TMDb English names #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/ui/region-language-sort
branch
9 times, most recently
from
609e022
to
7d4082c
Compare
TheCatLady
force-pushed
the
fix/ui/region-language-sort
branch
from
e229332
to
3a80d09
Compare
sct
approved these changes
Mar 16, 2021
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, items in the dropdowns are not actually alphabetized by the strings displayed to the user, but by the English names returned from TMDb.
Not only does this result in the list not being alphabetized in non-English languages, but it actually causes some entries to appear out of order in English as well.
One example is the "zh" language code, for which TMDb returns an English name of "Mandarin" but is usually localized to "Chinese."
Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed
N/A