Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notif): allow users to enable/disable specific agents #1172

Merged
merged 31 commits into from
Apr 13, 2021
Merged

feat(notif): allow users to enable/disable specific agents #1172

merged 31 commits into from
Apr 13, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Mar 15, 2021 •
edited

Description

  • Allows users to enable/disable specific agents
  • Refactors setting navigation tabs into a new SettingsTabs component
  • Adds tabbed user notification settings and hides tabs for settings which cannot be enabled (e.g., don't allow user to configure email settings if the owner/admin has not set up and enabled email notifications)
  • Adds new shared settings tabs component for settings navigation elements
  • Modifies Yup validation to only enforce required fields when the notification agent is enabled
  • Refactors email notification agent to reduce duplicated logic/code
  • Improves notification logging
  • Removes redundant "Enable Notifications" setting, since each agent can be enabled/disabled on its own
  • Fixes test function for email notification agent to use form values instead of saved settings

Screenshot (if UI-related)

image
image
image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner March 15, 2021 00:53
@TheCatLady TheCatLady force-pushed the feat/ui/user-notification-agent-settings branch 24 times, most recently from b49c31e to 5146ede Compare March 21, 2021 23:20
@TheCatLady TheCatLady force-pushed the feat/ui/user-notification-agent-settings branch 2 times, most recently from 5898473 to ee18075 Compare March 23, 2021 01:27
@TheCatLady TheCatLady mentioned this pull request Mar 23, 2021
Merged
@TheCatLady TheCatLady force-pushed the feat/ui/user-notification-agent-settings branch 2 times, most recently from b1653b9 to 0240f83 Compare March 24, 2021 04:37
@TheCatLady
fix(email): correct inconsistencies in email template formatting
67cd091
@TheCatLady
refactor: use bitfields for storing user-enabled notif agent types
4bebf8c
@TheCatLady
feat: improve notification agent logging
81edb3d
@TheCatLady
fix(ui): mark string fields as nullable so empty values are not type …
c83001f 
…errors
@TheCatLady
fix: add validation for PGP-related inputs
15cf4fe
@TheCatLady
fix: correctly fetch user in user settings & log mentioned IDs for Di…
73d63b3 
…scord notifs
@TheCatLady
fix(ui): fix mobile nav dropdown text & add hover effect to button-st…
af73efc 
…yle tabs
@TheCatLady
fix(notif): process admin email notifications asynchronously
51af957
@TheCatLady
fix(logging): log name of notification type instead of its enum value
c0dcd90
@TheCatLady
fix: mark required fields and pass all user settings values to API
75a69be
@TheCatLady
fix(frontend): call mutate after changing email/Discord/Telegram glob…
5b05ed6 
…al notif settings
@TheCatLady
refactor: get global notif settings from relevant API endpoints inste…
a57139c 
…ad of adding to public settings
@TheCatLady
fix(notif): fall back to email notifications being enabled (default) …
c0ca64c 
…if user settings do not exist
@TheCatLady
fix(notif): do not set notifyUser for MEDIA_PENDING or MEDIA_AUTO_APP…
3241bf6 
…ROVED
@TheCatLady
fix: expose notif enabled settings in user notif endpoints & remove g…
748b230 
…lobal enable notif setting
@TheCatLady
fix(notif): remove unnecessary allowed_mentions object from Discord p…
90d2aaf 
…ayload
@TheCatLady
fix(notif): use form values for email test notification
f1395ed
@TheCatLady
fix: make suggested changes and regenerate DB migration
373424d
@TheCatLady
fix: loosen validation of PGP keys
c774385
@TheCatLady
fix: fix user profile settings routes
9956cd6
@TheCatLady
fix: remove route guard from profile pages
85c6d2a
@TheCatLady TheCatLady force-pushed the feat/ui/user-notification-agent-settings branch from 2b7fb1e to 85c6d2a Compare April 13, 2021 03:25
@sct sct enabled auto-merge (squash) April 13, 2021 03:31
@sct sct merged commit 46c4ee1 into develop Apr 13, 2021
@sct sct deleted the feat/ui/user-notification-agent-settings branch April 13, 2021 03:31
TheCatLady added a commit that referenced this pull request Apr 13, 2021
@TheCatLady
docs: update Telegram docs to reflect changes in #1172
98cd02b
sct pushed a commit that referenced this pull request Apr 13, 2021
@TheCatLady
docs: add Pushbullet, Pushover, Slack, Telegram (#1268) [skip ci]
ad6f815 
* docs: add Pushbullet, Pushover, Telegram

* docs: correction based on feedback from @costaht

* docs: add Slack

* docs: update Telegram docs to reflect changes in #1172

* docs: clarify PGP key format

* docs: edit Pushover documentation
@github-actions
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase verboseness of notification logs Specify notification agent per user
2 participants
@TheCatLady @sct