fix(ui): do not require numeric value in FormattedRelativeTime #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
approved these changes
Mar 21, 2021
TheCatLady
force-pushed
the
fix/ui/formatted-relative-time-numeric
branch
from
c2c82f8
to
2ca5f89
Compare
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets
numericattribute ofFormattedRelativeTimeelements toauto. This fixes cases where a string like "in 0 seconds" will be displayed to the user, instead of a more readable string like "now."Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed
N/A