fix(frontend): 'Recent Requests' slider should link to request list w/ same filter #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/frontend/request-list-filter
branch
15 times, most recently
from
68072e7
to
fa9b2ec
Compare
sct
approved these changes
Mar 29, 2021
TheCatLady
force-pushed
the
fix/frontend/request-list-filter
branch
from
fa9b2ec
to
e48a272
Compare
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Recent Requests" slider on the Discover page only shows "unavailable" requests -- requests with any request status, but with media status of any value but "available."
This slider should link to a request list view with the same filter, so this PR adds the missing filter type to the request list and updates the slider link to pass a new
filterquery parameter.Edit: Changed "Recent Requests" slider and its link to use the "all" instead of "unavailable" filter.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A