fix(ui): display asterisk indicator on required field labels #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/ui/required-field-indicator
branch
from
b9d8b31
to
1259564
Compare
sct
approved these changes
Mar 20, 2021
TheCatLady
force-pushed
the
fix/ui/required-field-indicator
branch
from
1259564
to
b6d16a6
Compare
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required fields should be denoted clearly as such, so that a user can easily tell which fields are required and which are optional.
Also fixes the "SSL" setting strings to say "Enable SSL" (to match the string in email notification settings), and resolves the sharing/conflict between the Plex setting option & the badge used on the Services page (since the context is different, this shared string created an issue for some translations).
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A