Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): display movie/series original title #1240

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Mar 20, 2021

Description

Displays the original title of a movie/series if its original language does not match the user's locale.

Also fixes an issue where there's an extra margin above the summary/overview when the tagline is missing.

Screenshot (if UI-related)

  • Example where locale does not match media original language:
    image
  • Example where locale matches media original language:
    image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner March 20, 2021 17:16
@TheCatLady TheCatLady force-pushed the feat/ui/media-original-title branch 8 times, most recently from d4dc008 to c633b33 Compare March 24, 2021 14:10
@sct sct enabled auto-merge (squash) March 24, 2021 16:30
@sct sct merged commit 7230915 into develop Mar 24, 2021
@sct sct deleted the feat/ui/media-original-title branch March 24, 2021 16:34
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants