fix: fetch localized person details from TMDb #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/frontend/person-details-language
branch
from
f153436
to
c4e28b2
Compare
sct
reviewed
Mar 21, 2021
TheCatLady
force-pushed
the
fix/frontend/person-details-language
branch
6 times, most recently
from
d4a1e86
to
c70e7bf
Compare
TheCatLady
force-pushed
the
fix/frontend/person-details-language
branch
from
c70e7bf
to
bba5195
Compare
sct
approved these changes
Mar 22, 2021
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We aren't setting the
languageparameter when fetching person details, so the biography is currently always in English.Edit: Also, add missing person details (DOB, hometown, alternate names).
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A