Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): correct strings for library sync button & user import toast #1252

Merged
merged 3 commits into from
Mar 21, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Mar 21, 2021

Description

  • Changes "Scan Plex Libraries" button to say "Sync Libraries"
  • Fixes Plex user import toast message for case where there are no users imported
  • Removes unused "User Rating" strings from media detail pages

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner March 21, 2021 16:34
@TheCatLady TheCatLady changed the title fix(lang): 'scan plex libraries' should actually be 'sync' fix(lang): correct strings for library sync button & user import toast Mar 21, 2021
@TheCatLady TheCatLady force-pushed the fix/lang/scan-plex-libraries branch 2 times, most recently from c860049 to 85ad88e Compare March 21, 2021 17:55
@sct sct enabled auto-merge (squash) March 21, 2021 23:03
@sct sct merged commit cb5ca7a into develop Mar 21, 2021
@sct sct deleted the fix/lang/scan-plex-libraries branch March 21, 2021 23:07
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants