fix(ui): restore saved states of quota override checkboxes #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
requested changes
Mar 24, 2021
Comment on lines
61
to
62
| setMovieQuotaEnabled(!!data?.movieQuotaLimit && !!data?.movieQuotaDays); | ||
| setTvQuotaEnabled(!!data?.tvQuotaLimit && !!data?.tvQuotaDays); |
There was a problem hiding this comment.
You must check if the limits are null/undefined here or unlimited won't check the box.
sct
approved these changes
Mar 25, 2021
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the "Enable Override" checkboxes reset to unchecked when you return to the user settings page after saving. (This is just a visual bug, the values are saved properly to the DB.)
Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed
N/A