Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fix getShowByTvdbId() error message #1314

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

Currently, we are logging messages such as the following:

2021-03-29T08:30:25.985Z [error][Sonarr Scan]: Failed to process Sonarr media {"errorMessage":"[TMDb] Failed to get TV show using the external TVDB ID: [TMDb] Failed to find a TV show with the provided TVDB ID: 309496","title":"Rock Records In Love"}

This is because we are throwing an error in getShowByTvdbId() which gets caught by a try/catch block which then re-throws and adds to the message.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner March 29, 2021 17:56
server/api/themoviedb/index.ts Outdated Show resolved Hide resolved
@TheCatLady TheCatLady force-pushed the fix/backend/getShowByTvdbId-error-message branch 3 times, most recently from 295849e to 6f7458a Compare March 31, 2021 10:20
@TheCatLady TheCatLady force-pushed the fix/backend/getShowByTvdbId-error-message branch from 6f7458a to 1137320 Compare March 31, 2021 10:58
@sct sct merged commit fe8d346 into develop Mar 31, 2021
@sct sct deleted the fix/backend/getShowByTvdbId-error-message branch March 31, 2021 11:11
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants