Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): hide alert when email notifs are already configured #1335

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

  • If email notifications are already enabled, do not show alert about the email notification requirement for automatically generating passwords
  • If email notifications are not enabled, do not show the checkbox for automatically generating passwords
  • Fix capitalization of the checkbox label

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner March 30, 2021 20:26
@TheCatLady TheCatLady force-pushed the fix/ui/generate-password branch 2 times, most recently from 2317207 to dabb556 Compare March 31, 2021 10:58
@TheCatLady TheCatLady marked this pull request as draft March 31, 2021 12:15
@TheCatLady TheCatLady marked this pull request as ready for review April 13, 2021 04:20
@TheCatLady TheCatLady force-pushed the fix/ui/generate-password branch 2 times, most recently from b25eb0d to ebfd1c2 Compare April 14, 2021 01:28
@sct sct merged commit 5117987 into develop Apr 14, 2021
@sct sct deleted the fix/ui/generate-password branch April 14, 2021 03:32
@github-actions
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants