fix: fall back to English genre names #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/lang/genre-name-eng-fallback
branch
from
68f62b9
to
b6e7ef0
Compare
|
Would it be possible to select other fallback language different of english? |
No. TMDb actually already automatically falls back to English on other API endpoints, so we need to use English for consistency. Also, other languages possibly have the same issue with missing translations. Also, this fallback is not specifically for Catalan. The default language of the Overseerr UI is English, so it makes sense to fall back to English. |
TheCatLady
force-pushed
the
fix/lang/genre-name-eng-fallback
branch
from
b6e7ef0
to
c8148ad
Compare
TheCatLady
force-pushed
the
fix/lang/genre-name-eng-fallback
branch
from
c8148ad
to
2b318fb
Compare
sct
approved these changes
Apr 6, 2021
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TMDb returns
nullfor genre names in some languages (e.g., Catalan), which results in odd behavior for those locales (genre cards with no text and genre pages with no genre name).This PR adds a fall back to English genre names when a localized name is not provided by TMDb.
Note: TMDb is falling back to English genre names in the
genresobject returned by their/movie/{movie_id}and/tv/{tv_id}API endpoints (used by movie/series detail pages). They simply aren't falling back to English on their/genre/movie/listand/genre/tv/listendpoints. 🤦🏻♀️Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed