Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various fixes for new tags feature #1369

Merged
merged 4 commits into from
Apr 5, 2021
Merged

fix: various fixes for new tags feature #1369

merged 4 commits into from
Apr 5, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

  • Resolve Cannot read property 'length' of undefined error that results when checking for override Radarr tags (Error when requesting movies #1368)
  • Correct capitalization of Radarr/Sonarr in logging messages in MediaRequest.ts
  • Edit language strings for "No tags." (changed capitalization & added period) and "Anime Tags" (was previously just "Tags")
  • Make behavior of different tag select elements consistent in their display of a loading message and being disabled while loading tags

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner April 5, 2021 18:45
@sct sct merged commit b4450a3 into develop Apr 5, 2021
@sct sct deleted the fix/tags branch April 5, 2021 22:56
@github-actions
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when requesting movies
2 participants
@TheCatLady @sct