Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plex): use server 'address' returned by Plex API #1379

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

This PR updates the /plex/devices/servers API endpoint to try to connect to Plex using the returned address property, rather than trying to parse the hostname out of the uri property.

This resolves an issue with automatic server configuration reported by the folks over at LSIO 馃惐

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner April 7, 2021 20:21
@TheCatLady TheCatLady force-pushed the fix/plex/automatic-server-config branch from 424af7b to a1c4090 Compare April 7, 2021 23:16
@sct sct enabled auto-merge (squash) April 8, 2021 00:01
@TheCatLady TheCatLady force-pushed the fix/plex/automatic-server-config branch from a1c4090 to a22dbb3 Compare April 8, 2021 00:02
@sct sct merged commit 33542c9 into develop Apr 8, 2021
@sct sct deleted the fix/plex/automatic-server-config branch April 8, 2021 00:07
@github-actions
Copy link

馃帀 This PR is included in version 1.23.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants