Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix outofdate string & display version status badge in Settings > About #1417

Merged
merged 6 commits into from
Apr 14, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Apr 13, 2021

Description

LSIO Overseerr images are tagged with the short hash rather than the full one (and they also don't skip commits tagged with [skip ci]).

This PR:

  • Handles short hash appropriately
  • Fixes capitalization of Out of Date sidebar string
  • Uses "warning" instead of "success" color for sidebar version status when version is out of date
  • Displays Out of Date or Up to Date badge on Settings > About page as appropriate

Screenshot (if UI-related)

Screenshot
Screenshot
Screenshot
Screenshot

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner April 13, 2021 16:46
@TheCatLady TheCatLady changed the title fix: handle short commit hashes fix: fix outofdate string & display version status badge in Settings > About Apr 13, 2021
@sct sct merged commit 4eb9209 into develop Apr 14, 2021
@sct sct deleted the fix/version-status branch April 14, 2021 00:25
@github-actions
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants