fix(ui): dim password field when password generation option is selected #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
reviewed
Apr 15, 2021
src/components/UserList/index.tsx
Outdated
| @@ -388,7 +388,9 @@ const UserList: React.FC = () => { | |||
| /> | |||
| </div> | |||
| </div> | |||
| <div className="form-row"> | |||
| <div | |||
| className={`form-row ${values.genpassword && 'opacity-50'}`} | |||
There was a problem hiding this comment.
this will end up printing out the class name false when values.genpassword is false. You shouldn't use the && pattern like this in anything except for rendering React components.
There was a problem hiding this comment.
Ah okay, fixed!
sct
approved these changes
Apr 15, 2021
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dims password field in
Create Local Usermodal whenAutomatically Generate Passwordis checked, so that it is clearer that the password field is disabled.Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed
N/A