fix(notif): include year in notifications #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
feat/notif/include-year
branch
2 times, most recently
from
f841f84
to
58d5db3
Compare
TheCatLady
force-pushed
the
feat/notif/include-year
branch
from
e61f61f
to
f98938c
Compare
sct
approved these changes
Apr 18, 2021
sct
changed the title
|
🎉 This PR is included in version 1.23.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the year to media-related notifications (i.e., sets the
subjectin the notification payload toMedia Name (Year)).Also removes a leftover check for the
Enable Notificationsglobal setting (if a user previously had this unchecked, they would not be able to get notifications, and would have no way to re-enable notifications via the UI), and resolves an issue with some strings being shared/overwritten.Screenshot (if UI-related)
To-Dos
yarn buildIssues Fixed or Closed
N/A