fix(ui): change 'Disable Auto-Search' checkbox to 'Enable Automatic Search' #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwiseg0
approved these changes
Apr 20, 2021
TheCatLady
force-pushed
the
fix/ui/arr-auto-search
branch
from
9044a57
to
c5f9478
Compare
sct
approved these changes
Apr 21, 2021
|
🎉 This PR is included in version 1.23.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is confusing to have a checkbox to that disables something when it is checked.
This PR modifies the UI to fix this, while NOT making any changes to the API or how the setting is saved/recorded in
settings.json.Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A