Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch PGP regex to span multiple lines #1598

Merged
merged 3 commits into from
May 11, 2021
Merged

fix: switch PGP regex to span multiple lines #1598

merged 3 commits into from
May 11, 2021

Conversation

Jabster28
Copy link
Contributor

Description

copying PGP keys from any PGP client almost never results in a single-lined key, and as such I don't think the input regex should require it all to be in one line, as the openPGP NPM module allows for whitespace in their keys.

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@Jabster28 Jabster28 requested a review from sct as a code owner May 7, 2021 20:26
@TheCatLady TheCatLady self-requested a review May 7, 2021 20:43
TheCatLady
TheCatLady requested changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the regex for the private key in src/components/Settings/Notifications/NotificationsEmail.tsx. 🙂

@Jabster28 Jabster28 requested a review from TheCatLady May 10, 2021 16:33
TheCatLady
TheCatLady approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@TheCatLady TheCatLady left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this! 🙂 We should be able to get this merged as soon as @sct has a chance to review.

sct
sct approved these changes May 11, 2021
View reviewed changes
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks for this!

@sct sct merged commit d0703aa into sct:develop May 11, 2021
@sct
Copy link
Owner

sct commented May 11, 2021

@all-contributors please add @Jabster28 for code

@allcontributors allcontributors bot mentioned this pull request May 11, 2021
Merged
@allcontributors
Copy link
Contributor

@sct

I've put up a pull request to add @Jabster28! 🎉

@Jabster28 Jabster28 deleted the patch-1 branch May 11, 2021 03:58
@github-actions
Copy link

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

@TheCatLady TheCatLady TheCatLady approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jabster28 @sct @TheCatLady