Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add quotas, advanced options, and toggles to collection request modal #1742

Merged
merged 7 commits into from Dec 25, 2021
Merged

feat: add quotas, advanced options, and toggles to collection request modal #1742

merged 7 commits into from Dec 25, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Jun 6, 2021 •
edited

Description

Brings collection request modal up to par with the movie/series request modals:

  • Adds alert when user has auto-approve perms
  • Adds quota display
  • Adds advanced requester
  • Allows users to select individual movies from a collection

Also includes the following fixes:

  • Corrects swapped requiredquota strings
  • When partial series requests are disabled, correctly compare the number of unrequested seasons to the remaining quota (instead of the total limit)

Screenshot (if UI-related)

Before:
image

After:
image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner June 6, 2021 23:29
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 5 times, most recently from 9c3ee93 to 421ec97 Compare June 10, 2021 09:50
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 4 times, most recently from a9015a6 to 779dabd Compare June 20, 2021 19:45
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch from 779dabd to 087c516 Compare June 23, 2021 12:51
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 2 times, most recently from 1b9ba61 to 0910fa1 Compare July 13, 2021 13:15
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch from 0910fa1 to d418959 Compare August 24, 2021 02:12
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 4 times, most recently from 5f65d0d to 3b9445e Compare September 23, 2021 08:42
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 3 times, most recently from cebcf67 to a527122 Compare October 14, 2021 14:21
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 2 times, most recently from 5be7bb3 to ebc2ba6 Compare October 18, 2021 15:27
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 2 times, most recently from 874e852 to 33cc093 Compare October 26, 2021 21:30
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 3 times, most recently from db973bd to 27bd11b Compare December 4, 2021 23:49
@TheCatLady TheCatLady force-pushed the feat/collection-request-modal branch 3 times, most recently from 8fb8008 to 4af945c Compare December 11, 2021 19:00
sct
sct approved these changes Dec 25, 2021
View reviewed changes
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sct sct enabled auto-merge (squash) December 25, 2021 00:46
@sct sct merged commit af40212 into develop Dec 25, 2021
@sct sct deleted the feat/collection-request-modal branch December 25, 2021 01:10
@danshilm danshilm mentioned this pull request Dec 26, 2021
Closed
1 task
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced Options for Request Collection
2 participants
@TheCatLady @sct