Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): link processing/requested status badges to service URL #1761

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Jun 8, 2021

Description

Similar to how available / partially available status badges link to Plex, make processing / requested status badges clickable links to the *arrs (for users with the Manage Requests permission only).

Also adds a url prop to the Badge component and refactors the StatusBadge component to dedupe logic and fix missing inProgress spinner display for 4K available / partially available media items.

Additionally, fixes font weight of media rating values and link hover effects in request cards (both in the Discover page slider & request list). (Originally included in #1832.)

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner June 8, 2021 22:49
@TheCatLady TheCatLady force-pushed the feat/requested-badge branch 3 times, most recently from 4c0c823 to e925d3b Compare June 17, 2021 05:02
@TheCatLady TheCatLady force-pushed the feat/requested-badge branch 3 times, most recently from 68e1f46 to e015509 Compare June 23, 2021 12:51
@sct
Copy link
Owner

sct commented Sep 19, 2021

I think this should maybe only show for Admins? Just because I give a user permission to manage requests it doesn't mean they necessarily have access to radarr/sonarr.

@TheCatLady
Copy link
Collaborator Author

I think this should maybe only show for Admins? Just because I give a user permission to manage requests it doesn't mean they necessarily have access to radarr/sonarr.

Oh hmm, good point! I'll make that change.

@TheCatLady TheCatLady force-pushed the feat/requested-badge branch 3 times, most recently from 3d03ddf to 0c6f895 Compare September 23, 2021 08:41
@TheCatLady TheCatLady mentioned this pull request Oct 9, 2021
6 tasks
@TheCatLady TheCatLady force-pushed the feat/requested-badge branch 3 times, most recently from e84401d to 9aba63c Compare October 16, 2021 01:39
@sct sct enabled auto-merge (squash) October 16, 2021 15:18
@sct sct merged commit 032c14a into develop Oct 16, 2021
@sct sct deleted the feat/requested-badge branch October 16, 2021 15:53
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants