feat(ui): allow admins to edit & approve request from advanced request modal #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
reviewed
Sep 7, 2021
danshilm
changed the title
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
2 times, most recently
from
ddbbdfa
to
0450962
Compare
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
2 times, most recently
from
b8a43d5
to
2842b5c
Compare
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
2 times, most recently
from
0f52240
to
12901fa
Compare
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
from
12901fa
to
8140699
Compare
TheCatLady
reviewed
Oct 26, 2021
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
from
fab5a34
to
fc1ac0a
Compare
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
from
fc1ac0a
to
ca013b8
Compare
This changes the "Edit Request" button in the advanced request modal to "Edit & Accept Request" since the only thing an admin would do next is to accept the request. The button would stay the same for users without the manage request permissions; users who are editing their own requests or requesting content.
danshilm
force-pushed
the
feat/ui/request-modal-cta
branch
from
ca013b8
to
eb40760
Compare
1 task
sct
approved these changes
Dec 31, 2021
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the "Edit Request" button in the advanced request modal to "Edit & Accept Request" since the only thing an admin would do next is to accept the request.
The button would stay the same for users without the manage request permissions; users who are editing their own requests or requesting new content.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed