Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add production countries to movie/TV detail pages #2170

Merged
merged 3 commits into from Dec 25, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Oct 7, 2021

Description

Adds production country info to movie/TV detail pages. (Unfortunately, TMDb doesn't provide a way to filter Discover/search results by country at this time, so this is a simple list and does not link to a filtered view.)

Also fixes TV detail page network list not using localized list delimiter.

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner October 7, 2021 20:17
@TheCatLady TheCatLady force-pushed the feat/production-countries branch 3 times, most recently from 4bcf5c7 to ce524a5 Compare October 14, 2021 14:22
@TheCatLady TheCatLady force-pushed the feat/production-countries branch 2 times, most recently from d01a92d to e5738ee Compare October 18, 2021 15:26
@TheCatLady TheCatLady force-pushed the feat/production-countries branch 2 times, most recently from 8e0c774 to beabfd5 Compare October 26, 2021 21:29
@sct sct enabled auto-merge (squash) December 25, 2021 00:48
@sct sct merged commit 30b20df into develop Dec 25, 2021
@sct sct deleted the feat/production-countries branch December 25, 2021 01:18
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants