Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): better request/media cards for items without valid TMDb IDs #2181

Merged
merged 13 commits into from
Aug 20, 2022

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Oct 9, 2021

Description

Currently, if a request's TMDb is not valid, we display a vague message that doesn't give any clues as to what the media item was.

This PR adds additional details, including the request type (movie or series), the TMDb/TVDB IDs, the requester, and the request date. This should help admins identify the media that is associated with "broken" requests (even if these IDs are no longer valid, they can be useful in matching broken requests to items added to Radarr/Sonarr).

Additionally, we currently display a placeholder title card for available media without valid TMDb IDs. This PR also adds an error card that allows for deletion of these items.

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Cypress tests

Issues Fixed or Closed

@samwiseg0
Copy link
Collaborator

samwiseg0 commented Oct 9, 2021

Can we add the title to this please? The ID is not helpful since it could have been deleted and there is no good way to know what it was at that point.

@TheCatLady
Copy link
Collaborator Author

TheCatLady commented Oct 9, 2021

Can we add the title to this please? The ID is not helpful since it could have been deleted and there is no good way to know what it was at that point.

As discussed previously, there's no way to do that currently. The IDs can help locate the items in the *arrs if the requests have already been approved.

@samwiseg0
Copy link
Collaborator

samwiseg0 commented Oct 9, 2021

Can we add the title to this please? The ID is not helpful since it could have been deleted and there is no good way to know what it was at that point.

As discussed previously, there's no way to do that currently. The IDs can help locate the items in the *arrs if the requests have already been approved.

Why can't we cache the title when it is requested? We can then only use that title if the ID becomes invalid. I think knowing what the user intended to request is important. We did discuss it but you were more concerned about the translations. Which I think having a way to know what has been orphaned is more important?

Like you stated only if it was approved would the other ID be useful. I have had many instances where that is not the case since I had not approved the request.

@TheCatLady
Copy link
Collaborator Author

Why can't we cache the title when it is requested? We can then only use that title if the ID becomes invalid. I think knowing what the user intended to request is important. We did discuss it but you were more concerned about the translations. Which I think having a way to know what has been orphaned is more important?

Like you stated only if it was approved would the other ID be useful. I have had many instances where that is not the case since I had not approved the request.

Either way, that's beyond the scope of this PR, and maybe something to consider for the future. I'm not making DB changes here, just displaying the info we already have.

@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch 4 times, most recently from 5f3fa29 to c2d7c99 Compare October 16, 2021 15:58
@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch 2 times, most recently from 64a51c5 to abeeb95 Compare October 24, 2021 16:17
@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch 2 times, most recently from 8cc4eea to 8a2e40f Compare January 1, 2022 03:17
@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch 6 times, most recently from ada7c1c to 48027ec Compare January 20, 2022 14:00
@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch 2 times, most recently from f32ccf3 to c4b8971 Compare February 10, 2022 03:30
@stale

This comment was marked as resolved.

@stale stale bot added the stale label May 25, 2022
@TheCatLady TheCatLady removed the stale label May 26, 2022
@TheCatLady TheCatLady force-pushed the fix/frontend/invalid-tmdbid branch from d6ec681 to 834f976 Compare July 4, 2022 02:28
@cypress
Copy link

cypress bot commented Aug 16, 2022



Test summary

17 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit b63d842
Started Aug 19, 2022 9:59 PM
Ended Aug 19, 2022 10:01 PM
Duration 01:52 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@TheCatLady TheCatLady changed the title fix(frontend): display additional details for requests without valid TMDb IDs fix(frontend): better request/media cards for items without valid TMDb IDs Aug 18, 2022
@sct sct enabled auto-merge (squash) August 20, 2022 02:21
@sct sct merged commit 9bc1f89 into develop Aug 20, 2022
@sct sct deleted the fix/frontend/invalid-tmdbid branch August 20, 2022 02:21
@github-actions
Copy link

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants