-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): better request/media cards for items without valid TMDb IDs #2181
Conversation
1d07739
to
a06e95c
Compare
Can we add the title to this please? The ID is not helpful since it could have been deleted and there is no good way to know what it was at that point. |
As discussed previously, there's no way to do that currently. The IDs can help locate the items in the *arrs if the requests have already been approved. |
Why can't we cache the title when it is requested? We can then only use that title if the ID becomes invalid. I think knowing what the user intended to request is important. We did discuss it but you were more concerned about the translations. Which I think having a way to know what has been orphaned is more important? Like you stated only if it was approved would the other ID be useful. I have had many instances where that is not the case since I had not approved the request. |
Either way, that's beyond the scope of this PR, and maybe something to consider for the future. I'm not making DB changes here, just displaying the info we already have. |
5f3fa29
to
c2d7c99
Compare
64a51c5
to
abeeb95
Compare
abeeb95
to
0579fab
Compare
0579fab
to
971706a
Compare
8cc4eea
to
8a2e40f
Compare
ada7c1c
to
48027ec
Compare
48027ec
to
23e2bc8
Compare
f32ccf3
to
c4b8971
Compare
c4b8971
to
043a39e
Compare
043a39e
to
d6ec681
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d6ec681
to
834f976
Compare
834f976
to
1898322
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
1898322
to
2807cfa
Compare
8f81dfc
to
0b993ca
Compare
…equests in one place
e90e671
to
b63d842
Compare
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Currently, if a request's TMDb is not valid, we display a vague message that doesn't give any clues as to what the media item was.
This PR adds additional details, including the request type (movie or series), the TMDb/TVDB IDs, the requester, and the request date. This should help admins identify the media that is associated with "broken" requests (even if these IDs are no longer valid, they can be useful in matching broken requests to items added to Radarr/Sonarr).
Additionally, we currently display a placeholder title card for available media without valid TMDb IDs. This PR also adds an error card that allows for deletion of these items.
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed