-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): hide 'Recently Added' & 'Recent Requests' sliders when empty #2190
Conversation
958703f
to
35a2b1f
Compare
After a very small amount of use, these sliders are very rarely hidden so I am not sure what this really offers. I'd like users to know the sliders exist even when they are empty. It lets them know that the home page will have those items as soon as they start interacting with the app. |
It doesn't really make sense to show an empty slider though, right? They'll just appear as soon as they request something or any media is available. And I don't think advertising the fact that these sliders exist when they are empty really offers much value. I think it feels much more natural for the new slider to just appear when there is actually content to be shown? Also, one particular case to consider is where a user doesn't have request privileges and will never have requests to be displayed in the slider. |
Yeah not sure I agree. I think this is still a core aspect of Overseerr and the cases in where these will remain empty is exceedingly rare. Also, a user may not have the requests permission but they may have had it at some point. So there is no saying whether or not they have requests at the moment. |
Yeah, this is definitely is not a super common case. But the way I'm thinking of it is, Overseerr's Discover page is a feed of sorts... and it's natural for things to appear in feeds only when they are applicable/relevant. As for the case of the user without the request perms... yes, that is true. However, we would still display the slider if they had requests to view, and only hide it if the slider isn't relevant. I also personally have a couple of new users who like to browse but haven't requested anything (not because they don't have request perms, but because they are overly polite/courteous), and the empty requests slider occupies a nontrivial chunk of screen real estate near the top of the page unnecessarily. They already know they haven't submitted any requests yet; there's no need to remind them every time they open Overseerr 😅 |
cbdc7eb
to
53e9b16
Compare
05aa0e3
to
e8624dc
Compare
e8624dc
to
acbeff5
Compare
acbeff5
to
4cc7bda
Compare
4cc7bda
to
a7c7091
Compare
f474f4c
to
0da7e54
Compare
0e1c559
to
587dfab
Compare
587dfab
to
9b1ffb4
Compare
9b1ffb4
to
5d4c818
Compare
5d4c818
to
d3cc2c5
Compare
d3cc2c5
to
1125eef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cee647c
to
f12401e
Compare
fcd056e
to
ac532ee
Compare
28cc46d
to
35f93c3
Compare
35f93c3
to
51ab159
Compare
0d6b108
to
db6b47f
Compare
db6b47f
to
066def7
Compare
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
If the
Recently Added
and/orRecent Requests
sliders are empty, hide them instead of taking up valuable screen real estate to display nothing. 😉Also fixes a bug where users cannot click the
Recent Requests
slider heading in their profiles to view their own requests unless they have manage/view request perms.Screenshot (if UI-related)
N/A
To-Dos
yarn build
Issues Fixed or Closed
N/A