Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically fetch login screen backdrop images #2206

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Oct 15, 2021

Description

Dynamically fetch backdrop images to be displayed on the sign-in screen.

Uses TMDb's /trending endpoint, so no information about available or requested media is revealed.

Also, corrects the misspelling of createTmdbWithRegionLanguage.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner October 15, 2021 21:30
server/routes/index.ts Outdated Show resolved Hide resolved
server/routes/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sct sct merged commit 3486d0b into develop Oct 16, 2021
@sct sct deleted the feat/dynamic-backdrops branch October 16, 2021 00:54
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants