Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): notification type validation #2207

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Conversation

TheCatLady
Copy link
Collaborator

Description

For some reason, the Yup validation is not behaving as expected. This is a workaround to resolve #1866.

The issue fixed in this PR was also reported on Discord.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner October 15, 2021 23:30
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sct sct enabled auto-merge (squash) October 16, 2021 00:55
@sct sct merged commit 2f204b9 into develop Oct 16, 2021
@sct sct deleted the fix/notif-type-selector branch October 16, 2021 01:02
@schambers schambers mentioned this pull request Oct 16, 2021
3 tasks
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot save Discord Notification configuration when only Media Requested Notification Type selected.
2 participants