fix: address unhandled promise rejections & bump node to v16.13 #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/unhandled-promise-rejections
branch
5 times, most recently
from
4d86682
to
911153a
Compare
TheCatLady
force-pushed
the
fix/unhandled-promise-rejections
branch
from
816d360
to
4b712f5
Compare
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
node16 deprecated unhandled promise rejections, resulting in app termination when promise rejections are not handled.This PR fixes the many instances where Overseerr does not safeguard against failed TMDb API requests with
try/catchblocks, and also adds/tweaks logging.This PR also bumps the
nodetov16.13, to allow for verification in thedevelopbranch that there are no more instances of this issue that need to be addressed before the next stable release.Also of note:
/settings/radarr/{radarrId}/profilesis unused and thus was removed in this PR (there is no equivalent to retrieve Sonarr profiles)MediaRequestentity were refactored to reduce duplication of logicScreenshot (if UI-related)
N/A
To-Dos
yarn buildIssues Fixed or Closed
N/A