Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show alert/prompt when settings changes require restart #2401

Merged
merged 13 commits into from
Aug 16, 2022

Conversation

TheCatLady
Copy link
Collaborator

Description

Also removes the MANAGE_SETTINGS permission, since there aren't really any settings that should be available to non-admin users. (Also, some settings require a server restart to apply changes.)

Screenshot (if UI-related)

image
image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner January 8, 2022 06:28
@sct
Copy link
Owner

sct commented Jan 8, 2022

I don't think we should completely block the app in this case. If someone makes a breaking change by mistake then realizes right after saving, they can't fix it. Maybe a popup with a warning that they can close instead? Something that may appear on every page navigation. That way, if it's a mistake, they can revert the change?

@TheCatLady
Copy link
Collaborator Author

I don't think we should completely block the app in this case. If someone makes a breaking change by mistake then realizes right after saving, they can't fix it. Maybe a popup with a warning that they can close instead? Something that may appear on every page navigation. That way, if it's a mistake, they can revert the change?

Good call, will add a close button to the pop-up!

@stale

This comment was marked as resolved.

@cypress
Copy link

cypress bot commented Aug 16, 2022



Test summary

15 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit 771ce04
Started Aug 16, 2022 4:11 PM
Ended Aug 16, 2022 4:13 PM
Duration 02:12 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sct sct enabled auto-merge (squash) August 16, 2022 16:51
@sct sct merged commit f3e56da into develop Aug 16, 2022
@sct sct deleted the feat/restart-prompt branch August 16, 2022 16:58
@github-actions
Copy link

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants