-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show alert/prompt when settings changes require restart #2401
Conversation
I don't think we should completely block the app in this case. If someone makes a breaking change by mistake then realizes right after saving, they can't fix it. Maybe a popup with a warning that they can close instead? Something that may appear on every page navigation. That way, if it's a mistake, they can revert the change? |
Good call, will add a close button to the pop-up! |
90a6ed3
to
2e8c8dd
Compare
8afa082
to
05a5df9
Compare
05a5df9
to
13ce602
Compare
70c279f
to
179bf6b
Compare
179bf6b
to
c2f4c2c
Compare
11b6294
to
25f62de
Compare
5bb2254
to
5827b65
Compare
This comment was marked as resolved.
This comment was marked as resolved.
5827b65
to
43d28bf
Compare
43d28bf
to
06e55f7
Compare
06e55f7
to
aaa1069
Compare
7d50379
to
8ee6947
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
7f547c1
to
771ce04
Compare
771ce04
to
2cdd10f
Compare
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Also removes the
MANAGE_SETTINGS
permission, since there aren't really any settings that should be available to non-admin users. (Also, some settings require a server restart to apply changes.)Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed
N/A