Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): open media management slideover on status badge click #2407

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

TheCatLady
Copy link
Collaborator

Description

Modifies StatusBadge component to deeplink to media page with management slideover panel open when tmdbId and mediaType are defined.

Otherwise, falls back to the current behavior of linking to either plexUrl or serviceUrl depending on the status. This fallback is kept because it is useful when the TMDb ID is no longer valid (see #2181).

Also links issue status badges to issue pages.

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner January 10, 2022 05:09
@TheCatLady TheCatLady force-pushed the feat/frontend/status-badge-target branch 3 times, most recently from c673f73 to 26baf0f Compare January 15, 2022 18:49
@TheCatLady TheCatLady force-pushed the feat/frontend/status-badge-target branch from 026dc31 to bebe584 Compare January 19, 2022 18:24
@TheCatLady TheCatLady force-pushed the feat/frontend/status-badge-target branch from bebe584 to 550a3ec Compare January 20, 2022 01:21
@sct sct merged commit 1f5785d into develop Jan 20, 2022
@sct sct deleted the feat/frontend/status-badge-target branch January 20, 2022 03:40
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make clicking the status badge go to the movie settings instead.
2 participants