Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notif): show event in pop up notification for slack #2413

Merged
merged 4 commits into from
Jan 15, 2022

Conversation

danshilm
Copy link
Collaborator

Description

The text attribute being absent resulted in the pop up notification saying "That content can't be displayed".
This sets the text to be the name of event.

Screenshot (if UI-related)

Example:
Screen Shot 2022-01-12 at 6 25 01 PM

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@danshilm danshilm requested a review from sct as a code owner January 12, 2022 14:27
Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sct sct enabled auto-merge (squash) January 15, 2022 00:26
@sct sct merged commit d4438c8 into sct:develop Jan 15, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack Popup Notifications 'Content Cannot be Displayed' - missing text property
3 participants