Fix rectangular avatars getting stretched #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Use of the |
Didn't know, thanks for that! I'll change to that. |
sambartik
force-pushed
the
fix-avatar-aspectratio
branch
from
6237a76
to
569f392
Compare
|
It should be okay now. |
sambartik
force-pushed
the
fix-avatar-aspectratio
branch
from
64e8472
to
1141154
Compare
|
@all-contributors add @sambartik for code |
|
I've put up a pull request to add @sambartik! 🎉 |
This was referenced May 25, 2022
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the aspect ratio of profile pictures in dropdown is not being preserved, resulting in pictures looking "squished". Adding
object-fit: cover;to the image element fixes this (caniuse.).Screenshot (if UI-related)
Before:
After:
To-Dos
yarn buildIssues Fixed or Closed
No prior issue