fix: update Discord ID regex to include 19 digit IDs #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
requested changes
Jul 15, 2022
src/components/UserProfile/UserSettings/UserGeneralSettings/index.tsx
Outdated
Show resolved
Hide resolved
src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsDiscord.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: TheCatLady <52870424+TheCatLady@users.noreply.github.com>
|
Right, thanks for the heads up, probably shouldn't have deleted the entire todo list part of the PR |
sct
approved these changes
Aug 3, 2022
|
Thanks for fixing it up! |
|
@all-contributors please add @frank-cywong for code |
|
I've put up a pull request to add @frank-cywong! 🎉 |
1 task
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From July 22 onwards, new Discord accounts will have 19 digit Discord IDs (https://snowsta.mp/?l=en-us&z=6&f=atx10uuark-7ps), this is similar to #971 in terms of how it changes the regex.
Screenshot (if UI-related)
NA
To-Dos
NA
Issues Fixed or Closed
No such issue reported yet as the bug could only occur after July 22 at the earliest