Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tooltip foundation #2950

Merged
merged 3 commits into from
Aug 19, 2022
Merged

feat: tooltip foundation #2950

merged 3 commits into from
Aug 19, 2022

Conversation

sct
Copy link
Owner

@sct sct commented Aug 19, 2022

Description

  • Adds <Tooltip /> component, which you can use to wrap anything to add tooltips!
  • Also removed React import wherever possible since you no longer need to import it for JSX since React 17

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@sct
Copy link
Owner Author

sct commented Aug 19, 2022

Reviewing this might be annoying so for the tooltip stuff just look at the first commit on its own: 7f29ac6

@cypress
Copy link

cypress bot commented Aug 19, 2022



Test summary

15 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit ee4d65f
Started Aug 19, 2022 10:27 AM
Ended Aug 19, 2022 10:29 AM
Duration 01:48 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sct sct merged commit 16545ee into develop Aug 19, 2022
@sct sct deleted the feature/tooltips branch August 19, 2022 10:35
@github-actions
Copy link

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant