Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore option to cache and optimize images locally #2964

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

sct
Copy link
Owner

@sct sct commented Aug 22, 2022

Description

A few versions ago, NextJS fixed the local image generation to pass the cache control header from the origin. This means the locally created images are now correctly cached in the user's browser and performance has improved!

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@sct sct force-pushed the feature/reenable-cache-images branch from 6e19e57 to a933634 Compare August 22, 2022 16:23
@cypress
Copy link

cypress bot commented Aug 22, 2022



Test summary

23 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit a933634
Started Aug 22, 2022 4:29 PM
Ended Aug 22, 2022 4:32 PM
Duration 02:28 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sct sct merged commit 507227a into develop Aug 22, 2022
@sct sct deleted the feature/reenable-cache-images branch August 22, 2022 16:46
@github-actions
Copy link

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants