feat: season/episode list on series details #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
TheCatLady
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Looks great! Just a couple of comments.
Also, another minor thing -- I feel like there's a bit of visual disconnect between the season heading and the episode list. I think it should appear as one element that gets expanded (e.g., they should connect instead of having space between) instead of a button and some stuff that appears below.
TheCatLady
reviewed
Aug 24, 2022
TheCatLady
approved these changes
Aug 24, 2022
added 9 commits
August 24, 2022 12:57
sct
force-pushed
the
feature/episode-list
branch
from
c82faa5
to
390cd5a
Compare
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a season list (with availability status) and episode details to the series detail pages
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed