Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transition animation #2974

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: transition animation #2974

merged 1 commit into from
Aug 24, 2022

Conversation

OwsleyJr
Copy link
Collaborator

Description

Fix: Switched to using the headlessui transition component instead of the react-css-transition component due to new version breaking the animation.

  • Modified components to use new transition.
  • Removed transition file as we are no longer using it.

To-Dos

  • Successful build yarn build

@OwsleyJr OwsleyJr force-pushed the fix/transition-animation branch 3 times, most recently from 78b52ee to 82208f5 Compare August 24, 2022 05:45
@cypress
Copy link

cypress bot commented Aug 24, 2022



Test summary

24 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit fd775d1
Started Aug 24, 2022 4:38 PM
Ended Aug 24, 2022 4:41 PM
Duration 02:39 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@OwsleyJr OwsleyJr force-pushed the fix/transition-animation branch 2 times, most recently from 1c464a2 to d53b153 Compare August 24, 2022 16:08
@TheCatLady
Copy link
Collaborator

We no longer need the react-transition-group package, then! 😺

@OwsleyJr
Copy link
Collaborator Author

We no longer need the react-transition-group package, then! 😺

Ah, good catch!

switched to using headlessui transition instead of react-css-transition due to new version breaking the
animation
Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheCatLady TheCatLady merged commit 98028bf into develop Aug 24, 2022
@TheCatLady TheCatLady deleted the fix/transition-animation branch August 24, 2022 17:18
@github-actions
Copy link

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants