fix(ui): remove 'all' badge from request cards

[aedelbro]

Updates both RequestList/RequestItem and RequestCard components to no longer show ALL if all seasons are requested.

Originally, the number of requested seasons was added onto the ALL request (ie ALL - 4). After some discussion, it was decided to remove the ALL badge to keep the requests consistent.

Description

When viewing the request list / request cards, if ALL seasons are requested, it will show each of the seasons requested, compared to the ALL badge that would show before.

Original PR

Updates both RequestList/RequestItem and RequestCard components to contain number of seasons if 'ALL' seasons are requested

Description

When viewing the request list / request cards, if ALL seasons are requested, this will include the number of seasons in the badge. If scrolling through the list of requests, the user no longer needs to open the details in a new tab to see how many seasons have been requested

Screenshot (if UI-related)

Request List:

becomes:

Request Card:

becomes:

To-Dos

• Successful build yarn build

Note: While this isn't technically a bug, I chose fix over feat, as I didn't think it really qualified as a feature. Also, first time contributing, so hope this PR is up to standards 😄

[TheCatLady]

I think a better alternative would be to simply remove the logic for the ALL badge and display the season list, for consistency. 🤔

[aedelbro]

Personally, I like having the ALL summary badge. If there's a large number of seasons being requested (for example One Piece has 21), it becomes really hard to see what is being requested (granted having this many seasons is rare).
For the RequestCard, you can't tell if there's more than 5 seasons being requested.
For the RequestItem, (at my laptop screen resolution) you can't tell if there's more than 18 seasons being requested.

While there is a horizontal scroll, there's no indication of that.

My use case (and I'm sure many others), is typically to request all seasons of a series on discovery. Then as a new seasons airs, only that 1 season is requested.

Love to hear your thoughts as well 🤔

Comparison shots:

vs

and

vs

[TheCatLady]

Personally, I like having the ALL summary badge. If there's a large number of seasons being requested (for example One Piece has 21), it becomes really hard to see what is being requested (granted having this many seasons is rare). For the RequestCard, you can't tell if there's more than 5 seasons being requested. For the RequestItem, (at my laptop screen resolution) you can't tell if there's more than 18 seasons being requested.

While there is a horizontal scroll, there's no indication of that.

This is a UX issue that should be addressed, because it doesn't only apply to series where all seasons have been requested. It could also apply to series like One Piece where all but a few season were requested. I still feel we should be consistent in how we display the requested seasons.

I have never liked the ALL badge, and I feel like the addition of the season count makes it look even more tacky. I think we need to come up with some other to indicate that a series is fully requested.

My use case (and I'm sure many others), is typically to request all seasons of a series on discovery. Then as a new seasons airs, only that 1 season is requested.

If a series is requested (and thus monitored in Sonarr), new seasons will actually automatically be monitored and downloaded (this is not configurable, just how Sonarr works). Additional requests do not need to be submitted in Overseerr to grab new seasons.

[aedelbro]

If a series is requested (and thus monitored in Sonarr), new seasons will actually automatically be monitored and downloaded (this is not configurable, just how Sonarr works). Additional requests do not need to be submitted in Overseerr to grab new seasons.

I don't use Sonarr, as I like being picky about choosing sources 😅 , so I was unaware of that. Most people probably use Sonarr, so I guess strike that thought.

I have never liked the ALL badge, and I feel like the addition of the season count makes it look even more tacky. I think we need to come up with some other to indicate that a series is fully requested.

I've been mulling it over a bit more, and I can go ahead and remove the ALL badge logic you suggested. Even though I like the extra info of knowing everything has been requested, showing each individual season badge still address my main concern (having to open another tab to see what seasons have been requested).

Then there can be a proper separate discussion about how to indicate that all seasons have been requested (not sure if this PR is the place for that, if it is, I can keep it open).

Additionally, the UX of not being able to tell if there's more seasons to show, that can be addressed in a separate PR 😄 (Actual UI changes might be beyond my limited frontend experience, but I might try if I have time).

[TheCatLady]

If a series is requested (and thus monitored in Sonarr), new seasons will actually automatically be monitored and downloaded (this is not configurable, just how Sonarr works). Additional requests do not need to be submitted in Overseerr to grab new seasons.

I don't use Sonarr, as I like being picky about choosing sources 😅 , so I was unaware of that. Most people probably use Sonarr, so I guess strike that thought.

Ah, well if you don't use Sonarr, then those new seasons would not be automatically monitored (and thus Overseerr wouldn't mark them as "Requested" during a scan). So, you would be able to continue using Overseerr as you are currently.

P.S.- I am also super picky about media sources, btw -- Sonarr is highly configurable and you should be able to tweak it to honor your preferences.

[aedelbro]

@TheCatLady Sorry for the delay in making the fix; but got the commit and PR updated.

Where should the discussion take place, if at all, for showing if all seasons are requested? Discord / here?

Related but for a separate PR: I had some thoughts on the request card, in showing the season available / partially available / unavailable. A green badge for the season being available, a stripped green / purple for partially available, and the purple for requested.
Quick mock up like this:

If that sounds like a good idea, it could replace all of the partially available green with the stripped green / purple. I know contrast / accessibility could potentially be a concern with the stripes, so I wanted a full discussion before putting in work on it.

Any additional thoughts? Thanks 😄

[TheCatLady]

Where should the discussion take place, if at all, for showing if all seasons are requested? Discord / here?

The development channel in our Discord server is the best place to discuss.

Related but for a separate PR: I had some thoughts on the request card, in showing the season available / partially available / unavailable. A green badge for the season being available, a stripped green / purple for partially available, and the purple for requested. Quick mock up like this:

I really dislike the stripes... but the idea to show available items a different color is interesting. Let's move this discussion to Discord :)

[github-actions]

🎉 This PR is included in version 1.30.0 🎉

The release is available on:

• v1.30.0
• GitHub release

Your semantic-release bot 📦🚀