fix: failure to load SearchByNameModal #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/searchbynamemodal
branch
from
3e7c44d
to
28564bf
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
TheCatLady
force-pushed
the
fix/searchbynamemodal
branch
from
28564bf
to
01bc91f
Compare
sct
approved these changes
Aug 30, 2022
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2987 results in
SearchByNameModalalways being in aloadingstate when we are unable to match a TMDB item to a TVDB ID. TheSearchByNameModalalso did not get fully updated with the new styling.This PR also makes a minor update to the alert string displayed in the modal, and does not ask the user to select a match if there are no results returned from Sonarr (or if they do not have a Sonarr server configured).
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extract