Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): request card progress bar #3123

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Conversation

OwsleyJr
Copy link
Collaborator

@OwsleyJr OwsleyJr commented Nov 17, 2022

Description

Status Badge Progress Bar

As I know that this is a very requested feature, I thought I could implement it! The main feature of this PR is to display a movie/show progress on the status badge until it is finished processing. I also added to the tooltip a quick peek that will display more download information similar to the manageSlideover. Below I will go into detail on the exact changes.

  • Status badge

    • The core change is that it will now show the progress of each movie or show that is currently downloading. If the case is a show, then it will display the progress of each episode with the season and episode number.
    • If a show is partially available and in the process of downloading, the status badge will now display processing instead of partially available.
    • The progress is calculated from the download item that is being passed in from each parent component that houses the status badge.
  • Tooltip

    • Download block is now being passed into the tooltip on the status badge to display more information about the downloads progress.
    • Used ReactDOM.createPortal to prevent overflow-hidden on the parent component.
    • Added classname prop to make it dynamic.
    • Title on download block will change depending on user permissions.
  • Servarr backend

    • Added params to retrieve the season and episode number from the Sonarr API.
    • New optional type called episode added to DownloadBlock interface.

Screenshot (if UI-related)

Screenshot 2022-11-17 at 5 18 06 PM

Screenshot 2022-11-17 at 5 18 14 PM

Screenshot 2022-11-17 at 5 18 33 PM

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

@cypress
Copy link

cypress bot commented Nov 17, 2022



Test summary

25 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit 1e22c77
Started Dec 27, 2022 2:11 AM
Ended Dec 27, 2022 2:13 AM
Duration 02:31 💡
OS Linux Ubuntu - 22.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@OwsleyJr OwsleyJr changed the title Feat/request card progress bar feat(ui): request card progress bar Nov 18, 2022
@OwsleyJr OwsleyJr force-pushed the feat/request-card-progress-bar branch 7 times, most recently from 2003291 to 9dcd768 Compare November 20, 2022 05:45
server/api/servarr/base.ts Outdated Show resolved Hide resolved
@OwsleyJr OwsleyJr force-pushed the feat/request-card-progress-bar branch 3 times, most recently from aac2b0b to b33668f Compare November 26, 2022 03:37
@OwsleyJr OwsleyJr force-pushed the feat/request-card-progress-bar branch 4 times, most recently from 1b7ca08 to 56aef80 Compare November 29, 2022 22:38
@Fallenbagel
Copy link
Contributor

Fallenbagel commented Dec 12, 2022

Hi. Love the work on this PR, I just have a few comments on the progress bar design. I was thinking, wouldn't this design be more inline with the overall overseerr ui? (Just a thought)

(The purple background with light purple hue progress bar instead of transparent background with dark purple progress bar)

Screenshot_20221212_202758_Firefox Beta

@OwsleyJr
Copy link
Collaborator Author

Hi. Love the work on this PR, I just have a few comments on the progress bar design. I was thinking, wouldn't this design be more inline with the overall overseerr ui? (Just a thought)

(The purple background with light purple hue progress bar instead of transparent background with dark purple progress bar)

Screenshot_20221212_202758_Firefox Beta

Readability is easier if the background is black to contrast the progress bar. Also, the design already used in the PR is more inline with the direction Overseerr is headed. The new design of the request modal is a good example.

@OwsleyJr OwsleyJr force-pushed the feat/request-card-progress-bar branch 3 times, most recently from 628e701 to a058ac6 Compare December 26, 2022 05:46
@OwsleyJr OwsleyJr force-pushed the feat/request-card-progress-bar branch from a058ac6 to 1e22c77 Compare December 27, 2022 02:05
@sct sct enabled auto-merge (squash) December 27, 2022 02:07
@sct sct merged commit 03853a1 into develop Dec 27, 2022
@sct sct deleted the feat/request-card-progress-bar branch December 27, 2022 02:13
@github-actions
Copy link

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lenaxia pushed a commit to lenaxia/overseerr-oidc that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User Permission to see Movie/TvShow Download Status
3 participants