fix: added a refresh interval if download status is in progress #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1513 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
OwsleyJr
force-pushed
the
fix/progress-bar-updating
branch
7 times, most recently
from
7cff47f
to
895c008
Compare
danshilm
reviewed
Jan 26, 2023
OwsleyJr
force-pushed
the
fix/progress-bar-updating
branch
3 times, most recently
from
14ea136
to
eb4c8ee
Compare
OwsleyJr
force-pushed
the
fix/progress-bar-updating
branch
2 times, most recently
from
684a8fb
to
2f1d500
Compare
danshilm
reviewed
Feb 15, 2023
OwsleyJr
force-pushed
the
fix/progress-bar-updating
branch
from
2f1d500
to
b090240
Compare
OwsleyJr
force-pushed
the
fix/progress-bar-updating
branch
from
b090240
to
a066b7a
Compare
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
…3275) * fix: added a refresh interval if download status is in progress * refactor: switched to a function instead of useEffect * feat: added editable download sync schedule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progress bar would not fetch new download status progress if page was not refocused or reloaded. To solve this, I added a refreshInterval if there is a download to watch. I also added in a change to make the download sync editable, in case you want to grab the download status at a faster rate.
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed