fix: lock body scroll when using webkit #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1693 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
OwsleyJr
changed the title
OwsleyJr
force-pushed
the
fix/lock-body-scroll-webkit
branch
from
45b2446
to
401e2c2
Compare
OwsleyJr
force-pushed
the
fix/lock-body-scroll-webkit
branch
from
401e2c2
to
ea1d586
Compare
OwsleyJr
force-pushed
the
fix/lock-body-scroll-webkit
branch
from
ea1d586
to
a552918
Compare
sct
approved these changes
May 11, 2023
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved an outstanding issue with Mobile Safari(webkit) that prevented the useLockBodyScroll from working. This was especially noticeable when a modal was open and you could still scroll. Adding touch action "none" to the hook fixes this issue.
To-Dos
yarn build