Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radarr minimum availability field is not mandatory, but failure to add movies without it #345

Closed
therokh opened this issue Dec 16, 2020 · 1 comment

Comments

@therokh
Copy link

therokh commented Dec 16, 2020

Describe the bug
During service setup for Radarr, the Minimum Availability field does not need to be selected. However, if it is not, then requesting movies fails to add the movie to Radarr with an error logged.

In Overseerr:

Dec 17 00:26:30 med01.domain.com dockerd-current[1235]: 2020-12-16T13:56:30.993Z [info][Media Request]: Sent request to Radarr
Dec 17 00:26:34 med01.domain.com mono[2055]: [Fatal] RadarrErrorPipeline: Request Failed. POST /api/movie
Dec 17 00:26:35 med01.domain.com mono[2055]: [v3.0.1.4259] Newtonsoft.Json.JsonSerializationException: Error converting value "" to type 'NzbDrone.Core.Movies.MovieStatusType'. Path 'minimumAvailability', line 1, position 97. ---> System.ArgumentException: Must specify valid information for parsing in the string.
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Utilities.EnumUtils.ParseEnum (System.Type enumType, Newtonsoft.Json.Serialization.NamingStrategy namingStrategy, System.String value, System.Boolean disallowNumber) [0x000ae] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Converters.StringEnumConverter.ReadJson (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Object existingValue, Newtonsoft.Json.JsonSerializer serializer) [0x0007b] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: --- End of inner exception stack trace ---
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Converters.StringEnumConverter.ReadJson (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Object existingValue, Newtonsoft.Json.JsonSerializer serializer) [0x000f1] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.DeserializeConvertable (Newtonsoft.Json.JsonConverter converter, Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Object existingValue) [0x00055] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue (Newtonsoft.Json.Serialization.JsonProperty property, Newtonsoft.Json.JsonConverter propertyConverter, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty, Newtonsoft.Json.JsonReader reader, System.Object target) [0x00052] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject (System.Object newObject, Newtonsoft.Json.JsonReader reader, Newtonsoft.Json.Serialization.JsonObjectContract contract, Newtonsoft.Json.Serialization.JsonProperty member, System.String id) [0x00280] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject (Newtonsoft.Json.JsonReader reader, System.Type objectType, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerMember, System.Object existingValue) [0x00161] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerMember, System.Object existingValue) [0x0006d] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Boolean checkAdditionalContent) [0x000db] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.JsonSerializer.DeserializeInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType) [0x00054] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.JsonSerializer.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Newtonsoft.Json.JsonConvert.DeserializeObject (System.String value, System.Type type, Newtonsoft.Json.JsonSerializerSettings settings) [0x0002d] in <2676a2da6edc420e890ed28aa4572ee5>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at NzbDrone.Common.Serializer.Json.Deserialize (System.String json, System.Type type) [0x00000] in <d4aae811a4874dfeba09c43aad919c20>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Radarr.Http.Extensions.ReqResExtensions.FromJson (System.IO.Stream body, System.Type type) [0x00017] in <c9b9bf41521f48db85be41a82303919c>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Radarr.Http.Extensions.ReqResExtensions.FromJson[T] (System.IO.Stream body, System.Type type) [0x00000] in <c9b9bf41521f48db85be41a82303919c>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Radarr.Http.Extensions.ReqResExtensions.FromJson[T] (System.IO.Stream body) [0x00000] in <c9b9bf41521f48db85be41a82303919c>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Radarr.Http.REST.RestModule`1[TResource].ReadResourceFromRequest (System.Boolean skipValidate, System.Boolean skipSharedValidate) [0x0000b] in <c9b9bf41521f48db85be41a82303919c>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Radarr.Http.REST.RestModule`1[TResource].<set_CreateResource>b__43_0 (System.Object options) [0x00006] in <c9b9bf41521f48db85be41a82303919c>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.NancyModule+<>c__DisplayClass38_0`1[T].<Post>b__0 (System.Object args) [0x00047] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.NancyModule+<>c__DisplayClass40_0`1[T].<Post>b__0 (System.Object args, System.Threading.CancellationToken ct) [0x00047] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.Routing.Route`1[T].Invoke (Nancy.DynamicDictionary parameters, System.Threading.CancellationToken cancellationToken) [0x00017] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.Routing.DefaultRouteInvoker.Invoke (Nancy.Routing.Route route, System.Threading.CancellationToken cancellationToken, Nancy.DynamicDictionary parameters, Nancy.NancyContext context) [0x00086] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.Routing.DefaultRequestDispatcher.Dispatch (Nancy.NancyContext context, System.Threading.CancellationToken cancellationToken) [0x002b7] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com mono[2055]: at Nancy.NancyEngine.InvokeRequestLifeCycle (Nancy.NancyContext context, System.Threading.CancellationToken cancellationToken, Nancy.Bootstrapper.IPipelines pipelines) [0x0011d] in <e31b230dbd29407fadcc55713e0bbd0f>:0
Dec 17 00:26:35 med01.domain.com dockerd-current[1235]: 2020-12-16T13:56:35.917Z [error][Radarr]: Failed to add movie to Radarr. This might happen if the movie already exists, in which case you can safely ignore this error. {"errorMessage":"Request failed with status code 500","options":{"profileId":6,"qualityProfileId":6,"rootFolderPath":"/mnt/nas/Movies/","minimumAvailability":"","title":"Tenet","tmdbId":577922,"year":2020,"monitored":true,"searchNow":true}}

In Radarr:

Request Failed. POST /api/movie: Error converting value "" to type 'NzbDrone.Core.Movies.MovieStatusType'. Path 'minimumAvailability', line 1, position 97.

What version of Overseerr are you running?
1.6.0

To Reproduce
In the Radarr server settings, set Minimum Availability to 'Select minimum availability', then try to request/approve a movie.

Expected behavior
Minimum availability must be selected to save the server settings.

@therokh therokh added the bug label Dec 16, 2020
@sct
Copy link
Owner

sct commented Dec 16, 2020

Will get this fixed. Thanks for the report!

@sct sct added this to Planned in Beta Release Roadmap Dec 17, 2020
@sct sct moved this from Planned to In progress in Beta Release Roadmap Dec 17, 2020
@sct sct closed this as completed in 2fe53ec Dec 17, 2020
Beta Release Roadmap automation moved this from In progress to Done Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants