Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add pushover integration #574

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

ankarhem
Copy link
Contributor

@ankarhem ankarhem commented Jan 4, 2021

Screenshot (if UI related)

Initial view:

Expanded:

Todos

  • Sucessfully builds yarn build
  • Translation Keys yarn i18n:extract

Issues Fixed or Closed by this PR

@ankarhem
Copy link
Contributor Author

ankarhem commented Jan 4, 2021

Optionally we could allow setting the title (the one currently displaying New Request etc.) in settings and default to Overseerr for instance. And embedd the requested title information in the message instead. Let me know what you think.

Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's get it merged and try it out. We can adjust the message format with feedback from people who use Pushover.

@sct sct merged commit ee5d018 into sct:develop Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pushover as a notification agent
2 participants