Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add new radarr or sonarr if a name isn't added #575

Closed
Roshy10 opened this issue Jan 4, 2021 · 7 comments
Closed

Unable to add new radarr or sonarr if a name isn't added #575

Roshy10 opened this issue Jan 4, 2021 · 7 comments

Comments

@Roshy10
Copy link

Roshy10 commented Jan 4, 2021

Describe the bug
When following the initial setup wizard I tried to add Radarr. When I'd filled out the fields I thought necessary it wouldn't let me press save, I even added a name and I still couldn't press save. To get it to work I had to add the name, then press test, before it let me press save. It seems wrong that I should have to press test before I can save it after adding a name. The also applies to Sonarr

What version of Overseerr are you running?
1.15.0

To Reproduce
Steps to reproduce the behavior:

  1. Start with a fresh install of overseerr, and an existing Plex and Radarr (mine have content already in them but I don't know if that's relevant)
  2. Add the plex server, click scan and continue to the next page while it runs
  3. Click "+ Add Radarr Server"
  4. Enter the host, port, and API key
  5. Click "Test"
  6. Select your profiles
  7. The "Add Server" button is disabled (perhaps this is intentional at this point, if a name is required)
  8. Add a name to your server
  9. The "Add Server" button is still disabled
  10. Click "Test" again
  11. Now the "Add Server" button is enabled

Expected behavior
In the steps to reproduce, I would expect that at step 9 the button can be clicked. Also there could be an indicator of why the button is still disabled (and asterisk on required fields might help)

Screenshots
STR step 7
STR step 7

STR step 9
STR step 9

STR step 11
STR step 11

Desktop (please complete the following information):

  • OS: Ubuntu 20.04.1 LTS
  • Browser Firefox
  • Version 84.0 (64-bit)
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

👋 @Roshy10, we use the issue tracker exclusively for bug reports and feature requests. However, this issue appears to be a support request. Please use our support channels to get help with Overseerr.

@github-actions github-actions bot closed this as completed Jan 4, 2021
@samwiseg0
Copy link
Collaborator

I see what you mean. If you go to the name it then errors.

@Roshy10
Copy link
Author

Roshy10 commented Jan 4, 2021

Oh yeah, so it does, still seems a bit confusing though since it's not immediately apparent.

@samwiseg0
Copy link
Collaborator

I don't know if this is something that would actually need to be "fixed" as you cannot continue and that is really enough feedback to the user that something is not correct.

@Roshy10
Copy link
Author

Roshy10 commented Jan 5, 2021

I suppose it's more of a ux improvement than a bug, but I think it would still be beneficial

@sct sct closed this as completed in 860d71e Jan 18, 2021
@sct
Copy link
Owner

sct commented Jan 18, 2021

Changed the modals to now show red asterisks next to any field name that is required. This should help clarify that the server name is required.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants