Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Approve Series notice while requesting without permission to Auto Approve #687

Closed
kobaubarr191 opened this issue Jan 19, 2021 · 1 comment

Comments

@kobaubarr191
Copy link
Contributor

kobaubarr191 commented Jan 19, 2021

Describe the bug

  1. A user with Auto Approve Movies authorisation but no Auto Approve Series authorisation will also get the Auto Approve notice while requesting a series.
  2. A user with Auto Approve Series authorisation but no Auto Approve Movies authorisation will not get the Auto Approve notice while requesting a series.

This happens both with local and Plex users.

What version of Overseerr are you running?
1.17.0

To Reproduce
Steps to reproduce the behavior:

Auto Approve notice without permission to auto approve series

  1. Grant user permission Auto Approve Movies but not Auto Approve Series
  2. Go to a series.
  3. Click 'Request'
  4. See the notice in the pop-up window

No Auto Approve notice with permission to auto approve series

  1. Grant user permission Auto Approve Series but not Auto Approve Movies
  2. Go to a series.
  3. Click 'Request'
  4. The notice is not in the pop-up window

Expected behavior
A user that can only Auto Approve Movies should not see the notice that his request will be automatically approved and a user that can Auto Approve Series but cannot Auto Approve Series should see the notice that his series request will be automatically approved.

Screenshots
What a user sees with Auto Approve Movies and without Auto Approve Series
notice

What a user sees without Auto Approve Movies and with Auto Approve Series
nonotice

Desktop (please complete the following information):

  • OS: MacOS, Ubuntu
  • Browser: Chrome, Safari
  • Version: Chrome 87.0.4280.141, Safari 14.0.2

Smartphone (please complete the following information):

  • Device: iPhone 7
  • OS: iOS 14.3
  • Browser: Safari

Additional context
N/A

@github-actions
Copy link

🎉 This issue has been resolved in version 1.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants