fix(build): sqlite3 build error #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's get this rebased and we can merge it. |
updated package.json and yarn.lock to include a version of node-gyp that works with python3 instead of python2 for node-sqlite3
chriscpritchard
force-pushed
the
fix-sqlite3-build-error
branch
from
44dee74
to
9296621
Compare
done! |
sct
approved these changes
Jan 20, 2021
|
@all-contributors please add @chriscpritchard for code |
|
I've put up a pull request to add @chriscpritchard! 🎉 |
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added resolutions such that node-sqlite3 depends on the latest version of node-gyp
Description
Fixes build error related to sqlite3 on some platforms by using the latest version of node-gyp as a dependency resolution
Todos
yarn buildyarn i18n:extract